Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(examples): update grid example for deploy #7577

Merged
merged 6 commits into from
Jan 19, 2021
Merged

chore(examples): update grid example for deploy #7577

merged 6 commits into from
Jan 19, 2021

Conversation

joshblack
Copy link
Contributor

@joshblack joshblack commented Jan 14, 2021 •
edited
Loading

Closes #7566

Our Grid deployment was broken after our upgrade to Yarn, it appears that "export" is not recognized when we deploy into Netlify.

This PR updates our examples script to fail if the child process for building examples exits with a code that is not 0 and also updates our grid example to pass in the path prefix to parcel without an environment variable.

Changelog

New

Changed

  • Update tasks/examples.js to fail on child sub-process fail
  • Update packges/grid/examples/preview to not use environment variables for path preview

Removed

Testing / Reviewing

  • Verify the grid page works as expected in the netlify elements preview

@netlify
Copy link

netlify bot commented Jan 14, 2021 •
edited
Loading

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 5dbb627

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/600703b10d5665000793afcc

😎 Browse the preview: https://deploy-preview-7577--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 14, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: f081e63

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/6000d1f7f4a17e0007c38ad9

😎 Browse the preview: https://deploy-preview-7577--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 15, 2021 •
edited
Loading

✔️ Deploy preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 5dbb627

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/600703b132e5a60008f80bf3

😎 Browse the preview: https://deploy-preview-7577--carbon-components-react.netlify.app

@joshblack joshblack changed the title chore(examples): debug example script chore(examples): update grid example for deploy Jan 15, 2021
@joshblack joshblack marked this pull request as ready for review January 15, 2021 01:03
@joshblack joshblack requested a review from a team as a code owner January 15, 2021 01:03
emyarod
emyarod approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, grid preview is restored

@kodiakhq kodiakhq bot merged commit 4699dc0 into carbon-design-system:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakahn dakahn dakahn approved these changes

@emyarod emyarod emyarod approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grid demo page not working
3 participants
@joshblack @emyarod @dakahn